nandakumar131 commented on code in PR #7515: URL: https://github.com/apache/ozone/pull/7515#discussion_r1870828992
########## hadoop-hdds/tools/pom.xml: ########## @@ -179,20 +179,20 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>maven-compiler-plugin</artifactId> <configuration> <annotationProcessorPaths> - <path> - <groupId>org.apache.ozone</groupId> - <artifactId>hdds-config</artifactId> - <version>${hdds.version}</version> - </path> Review Comment: Is this not required anymore? ########## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java: ########## @@ -56,15 +56,20 @@ public GenericCli() { } public GenericCli(Class<?> type) { - cmd = new CommandLine(this); + this(CommandLine.defaultFactory(), type); + } + + public GenericCli(CommandLine.IFactory factory, Class<?> type) { Review Comment: nitpick: can we change the order of constructor arguments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
