adoroszlai commented on PR #7561:
URL: https://github.com/apache/ozone/pull/7561#issuecomment-2536151224
Thanks @sarvekshayr for working on this.
> `TestFSORepairTool` starts a new cluster for each test case, which is
required due to the tool's design.
I think we could improve the test to use a single cluster.
1. Add `@BeforeAll` setup
- start cluster
- create multiple connected and disconnected trees
- create non-FSO buckets
- stop OM
2. Keep separate test cases to validate various scenarios
3. Order tests (using
`@TestMethodOrder(MethodOrderer.OrderAnnotation.class)` and `@Order(...)`
annotations)
1. "dry run" in any order
2. "repair with filter"
3. "repair without filter" (should repair all remaining problems)
4. "validate cluster state after OM restart"
Please let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
