swamirishi commented on code in PR #7563:
URL: https://github.com/apache/ozone/pull/7563#discussion_r1881209059
##########
hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRocksDB.java:
##########
@@ -31,13 +32,21 @@
import java.io.IOException;
import java.time.Duration;
import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
/**
* Managed {@link RocksDB}.
*/
public class ManagedRocksDB extends ManagedObject<RocksDB> {
public static final Class<RocksDB> ORIGINAL_CLASS = RocksDB.class;
public static final int NOT_FOUND = RocksDB.NOT_FOUND;
+ /**
+ * SST file extension. Must be lower case.
+ * Used to trim the file extension when writing compaction entries to the log
Review Comment:
reverted this change. Not required
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -144,14 +143,8 @@ public class RocksDBCheckpointDiffer implements
AutoCloseable,
private static final String COMPACTION_LOG_ENTRY_INPUT_OUTPUT_FILES_DELIMITER
= ":";
- /**
- * SST file extension. Must be lower case.
- * Used to trim the file extension when writing compaction entries to the log
- * to save space.
- */
- static final String SST_FILE_EXTENSION = ".sst";
public static final int SST_FILE_EXTENSION_LENGTH =
- SST_FILE_EXTENSION.length();
+ ManagedRocksDB.SST_FILE_EXTENSION.length();
Review Comment:
We don't need it anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
