ArafatKhan2198 commented on code in PR #7554:
URL: https://github.com/apache/ozone/pull/7554#discussion_r1883351911
##########
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/schema/SchemaVersionTableDefinition.java:
##########
@@ -37,9 +39,12 @@
@Singleton
public class SchemaVersionTableDefinition implements ReconSchemaDefinition {
+ private static final Logger LOG =
LoggerFactory.getLogger(SchemaVersionTableDefinition.class);
+
public static final String SCHEMA_VERSION_TABLE_NAME =
"RECON_SCHEMA_VERSION";
private final DataSource dataSource;
private DSLContext dslContext;
+ private int latestSLV;
Review Comment:
The latestSLV field is needed to keep the recon and recon-codegen packages
independent. Directly accessing methods from the recon package from
recon-codegen would create unnecessary dependency. Attila has advised not to do
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
