adoroszlai commented on code in PR #37: URL: https://github.com/apache/ozone-docker-runner/pull/37#discussion_r1883573120
########## Dockerfile: ########## @@ -58,6 +58,11 @@ RUN sudo python3 -m pip install --upgrade pip COPY --from=go /go/bin/csc /usr/bin/csc +RUN dnf install -y unzip \ Review Comment: I think keeping `unzip` permanently is OK. Please move it to: https://github.com/apache/ozone-docker-runner/blob/0698816c8342823939c001b06bb77bf880479367/Dockerfile#L53-L54 ########## Dockerfile: ########## @@ -58,6 +58,11 @@ RUN sudo python3 -m pip install --upgrade pip COPY --from=go /go/bin/csc /usr/bin/csc +RUN dnf install -y unzip \ + && curl https://rclone.org/install.sh | sudo bash \ Review Comment: I'd rather re-implement download and extraction, instead of relying on a remote script that needs to be run as `root`. Checksums are also available, see https://rclone.org/release_signing/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
