adoroszlai opened a new pull request, #109:
URL: https://github.com/apache/ozone-site/pull/109

   ## What changes were proposed in this pull request?
   
   `mvn deploy` rebuilds the project, as it executes all [phases of the default 
lifecycle](https://maven.apache.org/ref/3.9.9/maven-core/lifecycles.html#default-lifecycle)
 up to `deploy`.  Not only is it unnecessary, it causes jars to be [different 
between Maven repo and binary 
tarball](https://github.com/apache/ozone/discussions/7560).
   
   `mvn deploy:deploy` just executes Maven Deploy Plugin's [`deploy` 
task](https://maven.apache.org/plugins/maven-deploy-plugin/usage.html#the-deploy-deploy-mojo),
 which is to upload artifacts to the remote repository.
   
   Flags `-Psign -DskipTests -Dbuildhelper.skipAttach` can be removed, since 
they are specific to other plugins, which would (before this change) be 
executed in various lifecycle phases.
   
   Skipping `:ozone-dist` seems to be unnecessary, too.  I don't see why we 
should not include it in the Maven repo.
   
   https://issues.apache.org/jira/browse/HDDS-11925
   
   ## How was this patch tested?
   
   Will be tested during next release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to