ashishkumar50 commented on PR #7532: URL: https://github.com/apache/ozone/pull/7532#issuecomment-2541131674
> @nandakumar131 Thanks for simplifying by skip processing the new lastTransactionId in some cases. One thing i think needs to corrected: This is not setting correctly in below case `lastProcessedTransactionId = keyValue != null ? keyValue.getKey() : -1;` > > Assume there are 15 transactions. And SCM returns maximum 10 transactions in one run. In this case transaction 1-10 is returned back and lastProcessedTransactionId is set it as 10 In second run, again lastProcessedTransactionId is set it as 10. I think it should set it as -1? I think above case is fine, as it will get next available transaction after 10th transaction to start next run which is fine. @nandakumar131, I have updated PR with your change. Can you please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
