[
https://issues.apache.org/jira/browse/HDDS-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-11908.
-------------------------------------
Fix Version/s: 2.0.0
Resolution: Fixed
> Snapshot diff DAG traversal should not skip node based on prefix presence
> -------------------------------------------------------------------------
>
> Key: HDDS-11908
> URL: https://issues.apache.org/jira/browse/HDDS-11908
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Swaminathan Balachandran
> Assignee: Swaminathan Balachandran
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
>
> Snapshot diff DAG traversal should not skip node based on prefix presence.
> Consider the case
> Snap1 has 1, 2, 3 files
> Say 1,4 compacted to => 5
> And 5, 6 => 7
> Snap 2 has 7, 2, 3 file.
> Now diff b/w Snap1 & Snap2 would be in 4 & 6 sst files.
> Consider 1 had +k & 4 had -k
> Now 5 would have neither of these files.
> But as per this condition:
> [https://github.com/apache/ozone/blob/b11b80707d4e6721c06966936ad87063ec107da6/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java#L1009-L1016]
> traversal on would skip node 5 thus traversal would never reach 1,4. We
> should not have this optmization check. This would end up not using the
> compaction even though it is not there.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
