adoroszlai commented on code in PR #7563:
URL: https://github.com/apache/ozone/pull/7563#discussion_r1884264887
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -825,18 +834,16 @@ private String getSSTFullPath(String
sstFilenameWithoutExtension,
* e.g. ["/path/to/sstBackupDir/000050.sst",
* "/path/to/sstBackupDir/000060.sst"]
*/
- public synchronized Optional<List<String>> getSSTDiffListWithFullPath(
- DifferSnapshotInfo src,
- DifferSnapshotInfo dest,
- String sstFilesDirForSnapDiffJob
- ) throws IOException {
+ public synchronized Optional<List<String>>
getSSTDiffListWithFullPath(DifferSnapshotInfo src,
+
DifferSnapshotInfo dest,
+ String
sstFilesDirForSnapDiffJob) {
Review Comment:
nit: Indenting parameters like this triggers unnecessary change whenever
visibility / return type / method name is updated.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java:
##########
@@ -69,6 +69,7 @@
import org.apache.ratis.util.TimeDuration;
import jakarta.annotation.Nonnull;
import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Assertions;
Review Comment:
nit: please use static import for assertions and mocks (see HDDS-9961).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
