sumitagrawl commented on code in PR #7377:
URL: https://github.com/apache/ozone/pull/7377#discussion_r1888679248
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -456,6 +460,7 @@ public long optimizeDirDeletesAndSubmitRequest(long
remainNum,
" totalRunCount: {}",
dirNum, subdirDelNum, subFileNum, (subDirNum - subdirDelNum),
Time.monotonicNow() - startTime, rnCnt);
+ metrics.incrementDirectoryDeletionTotalMetrics(dirNum + subdirDelNum,
subdirMoved, subFileNum);
Review Comment:
validate if {deletedDirsCount, movedDirsCount, movedFilesCount} as variable,
PurgeDir metrics {NumSubDirectoriesMoved, NumSubFilesMoved, NumDirPurged} and
Metrics here {dirDel, dirMove, fileMove} are same value, else this will create
confusion between metrics, and also with logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
