sarvekshayr commented on PR #7589: URL: https://github.com/apache/ozone/pull/7589#issuecomment-2552800561
> The check for service state should be more generic to support other types like Datanode and SCM. It should also be exposed to other repair subcommands. Sure, we can add a generic method to check for specific running services. > In [HDDS-11946](https://issues.apache.org/jira/browse/HDDS-11946) I plan to add a parent class for repair subcommands, I think that would be a good place to add this check. If you add the check here, I'll move it, along with the `--force` flag, to the parent class. That sounds good. Depending on which PR gets merged first, we can coordinate to make the necessary adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
