ChenSammi commented on code in PR #6871:
URL: https://github.com/apache/ozone/pull/6871#discussion_r1892183636
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretKey.java:
##########
@@ -52,21 +50,6 @@ public OzoneSecretKey(int keyId, long expiryDate, KeyPair
keyPair,
this.certSerialId = certificateSerialId;
}
- /*
- * Create new instance using default signature algorithm and provider.
- * */
- public OzoneSecretKey(int keyId, long expiryDate, byte[] pvtKey,
- byte[] publicKey) {
- Preconditions.checkNotNull(pvtKey);
- Preconditions.checkNotNull(publicKey);
-
- this.securityConfig = new SecurityConfig(new OzoneConfiguration());
- this.keyId = keyId;
- this.expiryDate = expiryDate;
- this.privateKey = SecurityUtil.getPrivateKey(pvtKey, securityConfig);
- this.publicKey = SecurityUtil.getPublicKey(publicKey, securityConfig);
- }
-
public int getKeyId() {
Review Comment:
Two readProtoBuf() methods calling this constructor look like not used
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
