errose28 commented on code in PR #7584:
URL: https://github.com/apache/ozone/pull/7584#discussion_r1892946913


##########
hadoop-hdds/docs/content/integration/Impala.md:
##########
@@ -0,0 +1,63 @@
+---
+title: Impala
+weight: 4
+menu:
+   main:
+      parent: "Application integrations"
+---
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+Starting with version **4.2.0**, Apache Impala provides full support for
+querying data stored in **Apache Ozone**. To utilize this functionality,
+ensure that your Ozone version is **1.4.0** or later.
+
+## Supported Access Protocols

Review Comment:
   I like this format of calling out the protocols and replication configs 
supported. Can we standardize this so all the integration pages have something 
similar? Maybe a markdown table at the top of each page would help.



##########
hadoop-hdds/docs/content/integration/Impala.md:
##########
@@ -0,0 +1,63 @@
+---
+title: Impala
+weight: 4
+menu:
+   main:
+      parent: "Application integrations"
+---
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+Starting with version **4.2.0**, Apache Impala provides full support for
+querying data stored in **Apache Ozone**. To utilize this functionality,
+ensure that your Ozone version is **1.4.0** or later.
+
+## Supported Access Protocols
+
+Impala supports the following protocols for accessing Ozone data:
+
+* ofs
+* s3a
+
+Note: The o3fs protocol is **NOT** supported by Impala.
+
+## Supported Bucket Types
+
+Impala is compatible with Ozone buckets configured with either:
+
+* RATIS (Replication)
+* Erasure Coding
+
+## Querying Ozone Data with Impala
+
+**If Ozone is configured as the default file system**, you can run Impala

Review Comment:
   Can you elaborate on what this means and what configs need to be set for 
this to be the case? Our docs should not assume too much hadoop knowledge as it 
raises the barrier to entry.



##########
hadoop-hdds/docs/content/integration/Impala.md:
##########
@@ -0,0 +1,63 @@
+---
+title: Impala
+weight: 4
+menu:
+   main:
+      parent: "Application integrations"
+---
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+Starting with version **4.2.0**, Apache Impala provides full support for
+querying data stored in **Apache Ozone**. To utilize this functionality,
+ensure that your Ozone version is **1.4.0** or later.

Review Comment:
   nit. Not sure we need the bold here, I think it reads smoother without it.
   nit. Let's not hard wrap the content. Although markdown doesn't make a 
distinction if there's no blank line in between, it becomes hard for later 
edits to add things in the middle without throwing off the balance.



##########
hadoop-hdds/docs/content/integration/Impala.md:
##########
@@ -0,0 +1,63 @@
+---
+title: Impala
+weight: 4
+menu:
+   main:
+      parent: "Application integrations"
+---
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+Starting with version **4.2.0**, Apache Impala provides full support for
+querying data stored in **Apache Ozone**. To utilize this functionality,
+ensure that your Ozone version is **1.4.0** or later.
+
+## Supported Access Protocols
+
+Impala supports the following protocols for accessing Ozone data:
+
+* ofs
+* s3a
+
+Note: The o3fs protocol is **NOT** supported by Impala.
+
+## Supported Bucket Types

Review Comment:
   We use bucket types to refer to OBS and FSO. What's described here are 
replication types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to