chungen0126 commented on PR #7612: URL: https://github.com/apache/ozone/pull/7612#issuecomment-2560909757
Thanks @adoroszlai for reviewing. > There are some leftover references in tests: > > https://github.com/apache/ozone/blob/5b27f6d938c67028f105767f104f65efb9f5637d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestSCMSnapshot.java#L47 > > https://github.com/apache/ozone/blob/5b27f6d938c67028f105767f104f65efb9f5637d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestSCMInstallSnapshot.java#L69 > > (please check if `TestSecureOzoneCluster` works without this setting) > > Also in `MiniOzoneClusterImpl`: > > https://github.com/apache/ozone/blob/5b27f6d938c67028f105767f104f65efb9f5637d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java#L769-L780 I'm leaving the reference in MiniOzoneClusterImpl because that enabling SCM Ratis in all tests with `MiniOzoneClusterImpl` leads to many tests failures. [TestSCMSnapshot.java](https://github.com/apache/ozone/blob/5b27f6d938c67028f105767f104f65efb9f5637d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestSCMSnapshot.java#L47) and [TestSCMInstallSnapshot.java](https://github.com/apache/ozone/blob/5b27f6d938c67028f105767f104f65efb9f5637d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestSCMInstallSnapshot.java#L69) should set `OZONE_SCM_HA_ENABLE_KEY ` to true because `MiniOzoneClusterImpl` is non-Ratis SCM by default. I believe we should fix this in [HDDS-6897](https://issues.apache.org/jira/browse/HDDS-6897). > (please check if TestSecureOzoneCluster works without this setting) `TestSecureOzoneCluster` doesn't work with `OZONE_SCM_HA_ENABLE_KEY` set to true but works without it. However, `MiniOzoneClusterImpl` is non-Ratis SCM by default. I'll convert this to draft and fix [HDDS-6897](https://issues.apache.org/jira/browse/HDDS-6897) first. I think that would make the change clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
