adoroszlai opened a new pull request, #7617:
URL: https://github.com/apache/ozone/pull/7617

   ## What changes were proposed in this pull request?
   
   Intermediate subcommands (ones that only group other subcommands) do not 
need to implement `Callable`.  Currently they show "missing subcommand" error 
as action.  The same can be achieved by using picocli built-in behavior.
   
   https://issues.apache.org/jira/browse/HDDS-11880
   
   ## How was this patch tested?
   
   Ran some of these without subcommands:
   
   ```
   $ ozone admin cert
   Missing required subcommand
   Usage: ozone admin cert [-hV] [COMMAND]
   Certificate related operations
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     info   Show detailed information for a specific certificate
     list   List certificates
     clean  Clean expired certificates from the SCM metadata.
   
   
   $ ozone admin container
   Missing required subcommand
   Usage: ozone admin container [-hV] [COMMAND]
   Container specific operations
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     list     List containers
     info     Show information about a specific container
     create   Create container
     close    close container
     report   Display the container summary report
     upgrade  Offline upgrade all schema V2 containers to schema V3 for this
                datanode.
   
   
   $ ozone admin replicationmanager
   Missing required subcommand
   Usage: ozone admin replicationmanager [-hV] [COMMAND]
   ReplicationManager specific operations
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     start   Start ReplicationManager
     stop    Stop ReplicationManager
     status  Check if ReplicationManager is running or not
   
   
   $ ozone debug container
   Missing required subcommand
   Usage: ozone debug container [-hV] [COMMAND]
   Container replica specific operations to be executed on datanodes only
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     list     Show container info of all container replicas on datanode
     info     Show container info of a container replica on datanode
     export   Export one container to a tarball
     inspect  Check the metadata of all container replicas on this datanode.
   
   
   $ ozone sh bucket
   Missing required subcommand
   Usage: ozone sh bucket [-hV] [COMMAND]
   Bucket specific operations
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     info                    returns information about a bucket
     list, ls                lists the buckets in a volume.
     create                  creates a bucket in a given volume
     setquota                Set quota of the buckets. At least one of the quota
                               set flag is mandatory.
     link                    creates a symlink to another bucket
     delete                  deletes a bucket
     addacl                  Add one or more new ACLs.
     removeacl               Remove one or more existing ACLs.
     getacl                  List all ACLs.
     setacl                  Set one or more ACLs, replacing the existing ones.
     clrquota                clear quota of the bucket. At least one of the 
quota
                               clear flag is mandatory.
     set-replication-config  Set replication config on bucket
     update                  Updates the parameters of the bucket
   
   
   $ ozone sh user
   Missing required subcommand
   Usage: ozone sh user [-hV] [COMMAND]
   Tenant user management
     -h, --help      Show this help message and exit.
     -V, --version   Print version information and exit.
   Commands:
     info                       Get tenant related information of a user
     assign                     Assign user accessId to tenant
     revoke                     Revoke user accessId to tenant
     assign-admin, assignadmin  Assign admin role to accessIds in a tenant
     revoke-admin, revokeadmin  Revoke admin role from accessIds in a tenant
     list, ls                   List users in a tenant
     get-secret, getsecret      Get secret given tenant user accessId. This
                                  differs from `ozone s3 getsecret` that this
                                  would not generate secret when the given 
access
                                  ID doesn't exist.
     set-secret, setsecret      Set secret for a tenant user accessId.
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/12502398129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to