adoroszlai commented on code in PR #7623:
URL: https://github.com/apache/ozone/pull/7623#discussion_r1898877875
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java:
##########
@@ -44,13 +45,18 @@ public class GenericCli implements Callable<Void>,
GenericParentCommand {
private boolean verbose;
@Option(names = {"-D", "--set"})
- private Map<String, String> configurationOverrides = new HashMap<>();
+ public void setConfigurationOverrides(Map<String, String> configOverrides) {
+ configOverrides.forEach(getOzoneConf()::set);
+ }
@Option(names = {"-conf"})
- private String configurationPath;
+ public void setConfigurationPath(String configPath) {
+ getOzoneConf().addResource(new Path(configPath));
+ }
+ private final Supplier<OzoneConfiguration> configSupplier =
+ MemoizedSupplier.valueOf(OzoneConfiguration::new);
private final CommandLine cmd;
- private OzoneConfiguration conf;
Review Comment:
Since almost all commands use the config, I think we can create the config
eagerly:
```java
private final OzoneConfiguration conf = new OzoneConfiguration();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
