devabhishekpal commented on PR #7626: URL: https://github.com/apache/ozone/pull/7626#issuecomment-2567433718
> Thanks for the effort on this @devabhishekpal > > From the looks of it The existing patch successfully tests table rendering, data loading on page mount, row selection, search filtering, API error handling, static and empty API responses, edge cases for search results, data display in rows, and integration with mock servers. > > The tests are missing coverage for features like: > > 1. `Pagination functionality`: Ensuring proper navigation between pages of datanodes. > 2. `Sorting behavior`: Verifying the sorting functionality for each column. > 3. `Column selection dropdown`: Testing the "Columns" dropdown for adding/removing table columns. > > Let me know if we are planning to integrate them in this scope. - So for pagination we will be getting an error as AntD internally calls scrollToTop which is not present in a virtual DOM environment - while this one won't cause any test to fail, it might cause false positives as the exception is being thrown from an internal library. - Sorting behaviour is better to be validated as a functional test via something like Cypress on an actual cluster rather than using dummy data. Similarly other test cases like testing out with large dataset (1000+ rows), auto-refresh functionality validation etc. will be better suited in a functional test environment (acceptance test) via docker. - For column selection the test cases need to be added for the respective `multiSelect.tsx` file which isn't in this scope and will be added later on as a part of component unit tests (search, selection etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
