elek commented on a change in pull request #1628:
URL: https://github.com/apache/ozone/pull/1628#discussion_r603901111
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/signature/StringToSignProducer.java
##########
@@ -125,7 +127,7 @@ public static String createSignatureBase(
headers,
queryParams,
!signatureInfo.isSignPayload());
-
+ System.out.println(canonicalRequest);
Review comment:
Yup, thanks. Removed.
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java
##########
@@ -57,6 +57,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
Review comment:
Thanks. reverted.
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -138,6 +146,21 @@ private OzoneClient getClient(OzoneConfiguration config)
return ozoneClient;
}
+ @NotNull
+ @VisibleForTesting
+ OzoneClient createOzoneClient() throws IOException {
+ if (omServiceID == null) {
+ return OzoneClientFactory.getRpcClient(ozoneConfiguration);
+ } else {
+ // As in HA case, we need to pass om service ID.
+ return OzoneClientFactory.getRpcClient(omServiceID,
+ ozoneConfiguration);
+ }
+ }
+
+ private void getSignatureInfo() {
Review comment:
Thanks, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
