[
https://issues.apache.org/jira/browse/HDDS-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909715#comment-17909715
]
Attila Doroszlai commented on HDDS-12002:
-----------------------------------------
Thanks [~chiacyu] for working on this.
I found the following methods to be unified in {{AbstractSubcommand}}:
{code}
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/UpgradeSubcommand.java
198: private static PrintWriter err() {
202: private static PrintWriter out() {
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/DBScanner.java
217: private static PrintWriter err() {
221: private static PrintWriter out() {
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/ValueSchema.java
165: private static PrintWriter err() {
169: private static PrintWriter out() {
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/RepairTool.java
67: private PrintWriter out() {
72: private PrintWriter err() {
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/Handler.java
126: protected PrintStream out() {
130: protected PrintStream err() {
{code}
Note that {{Handler}} returns {{PrintStream}}, so its callers need to be
converted to use {{PrintWriter}} instead. Few examples, there may be more:
{code}
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
455: public void print(PrintStream out) {
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/acl/AclOption.java
55: public void addTo(OzoneObj obj, ObjectStore objectStore, PrintStream out)
68: public void removeFrom(OzoneObj obj, ObjectStore objectStore, PrintStream
out)
81: public void setOn(OzoneObj obj, ObjectStore objectStore, PrintStream out)
{code}
> Move up out() and err() to AbstractSubcommand
> ---------------------------------------------
>
> Key: HDDS-12002
> URL: https://issues.apache.org/jira/browse/HDDS-12002
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Ozone CLI
> Reporter: Attila Doroszlai
> Assignee: Chia-Chuan Yu
> Priority: Major
>
> {{out()}} and {{err()}} methods are defined in few different subcommands.
> The goal of this task is to move the methods up to {{AbstractSubcommand}} to
> reduce duplication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
