adoroszlai commented on code in PR #7644: URL: https://github.com/apache/ozone/pull/7644#discussion_r1903220014
########## hadoop-hdds/hadoop-dependency-client/pom.xml: ########## @@ -45,168 +45,163 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <version>${hadoop.version}</version> <exclusions> <exclusion> - <groupId>com.nimbusds</groupId> - <artifactId>nimbus-jose-jwt</artifactId> - </exclusion> - <exclusion> - <groupId>org.xerial.snappy</groupId> - <artifactId>snappy-java</artifactId> - </exclusion> - <exclusion> - <groupId>org.apache.hadoop</groupId> - <artifactId>hadoop-annotations</artifactId> - </exclusion> - <exclusion> - <groupId>com.google.guava</groupId> - <artifactId>guava</artifactId> - </exclusion> - <!-- commons-cli is required by OzoneFsShell --> - <exclusion> - <groupId>org.apache.commons</groupId> - <artifactId>commons-math3</artifactId> + <groupId>ch.qos.reload4j</groupId> + <artifactId>reload4j</artifactId> </exclusion> <exclusion> - <groupId>commons-codec</groupId> - <artifactId>commons-codec</artifactId> + <groupId>com.fasterxml.jackson.core</groupId> + <artifactId>jackson-databind</artifactId> </exclusion> <exclusion> - <groupId>commons-io</groupId> - <artifactId>commons-io</artifactId> + <groupId>com.github.pjfanning</groupId> + <artifactId>jersey-json</artifactId> </exclusion> <exclusion> - <groupId>commons-net</groupId> - <artifactId>commons-net</artifactId> + <groupId>com.google.code.findbugs</groupId> + <artifactId>jsr305</artifactId> </exclusion> <exclusion> - <groupId>commons-collections</groupId> - <artifactId>commons-collections</artifactId> + <groupId>com.google.code.gson</groupId> + <artifactId>gson</artifactId> </exclusion> <exclusion> - <groupId>javax.servlet</groupId> - <artifactId>javax.servlet-api</artifactId> + <groupId>com.google.guava</groupId> + <artifactId>guava</artifactId> </exclusion> <exclusion> - <groupId>org.eclipse.jetty</groupId> - <artifactId>jetty-server</artifactId> + <groupId>com.jcraft</groupId> + <artifactId>jsch</artifactId> </exclusion> <exclusion> - <groupId>org.eclipse.jetty</groupId> - <artifactId>jetty-util</artifactId> + <groupId>com.nimbusds</groupId> + <artifactId>*</artifactId> </exclusion> <exclusion> - <groupId>org.eclipse.jetty</groupId> - <artifactId>jetty-servlet</artifactId> + <groupId>com.nimbusds</groupId> + <artifactId>nimbus-jose-jwt</artifactId> </exclusion> <exclusion> - <groupId>org.eclipse.jetty</groupId> - <artifactId>jetty-webapp</artifactId> + <groupId>com.sun.jersey</groupId> + <artifactId>jersey-core</artifactId> </exclusion> <exclusion> - <groupId>com.github.pjfanning</groupId> + <groupId>com.sun.jersey</groupId> <artifactId>jersey-json</artifactId> </exclusion> - <exclusion> - <groupId>com.google.code.findbugs</groupId> - <artifactId>jsr305</artifactId> - </exclusion> <exclusion> <groupId>com.sun.jersey</groupId> - <artifactId>jersey-core</artifactId> + <artifactId>jersey-server</artifactId> </exclusion> <exclusion> <groupId>com.sun.jersey</groupId> <artifactId>jersey-servlet</artifactId> </exclusion> <exclusion> - <groupId>com.sun.jersey</groupId> - <artifactId>jersey-json</artifactId> + <groupId>commons-beanutils</groupId> + <artifactId>commons-beanutils</artifactId> </exclusion> <exclusion> - <groupId>com.sun.jersey</groupId> - <artifactId>jersey-server</artifactId> + <groupId>commons-codec</groupId> + <artifactId>commons-codec</artifactId> + </exclusion> + <exclusion> + <groupId>commons-collections</groupId> + <artifactId>commons-collections</artifactId> + </exclusion> + <exclusion> + <groupId>commons-io</groupId> + <artifactId>commons-io</artifactId> </exclusion> <exclusion> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> </exclusion> <exclusion> - <groupId>log4j</groupId> - <artifactId>log4j</artifactId> + <groupId>commons-net</groupId> + <artifactId>commons-net</artifactId> </exclusion> <exclusion> - <groupId>ch.qos.reload4j</groupId> - <artifactId>reload4j</artifactId> + <groupId>dnsjava</groupId> + <artifactId>dnsjava</artifactId> </exclusion> <exclusion> - <groupId>commons-beanutils</groupId> - <artifactId>commons-beanutils</artifactId> + <groupId>javax.servlet</groupId> + <artifactId>javax.servlet-api</artifactId> </exclusion> <exclusion> - <groupId>org.apache.commons</groupId> - <artifactId>commons-lang3</artifactId> + <groupId>javax.servlet.jsp</groupId> + <artifactId>*</artifactId> </exclusion> <exclusion> - <groupId>org.slf4j</groupId> + <groupId>log4j</groupId> + <artifactId>log4j</artifactId> + </exclusion> + <exclusion> + <groupId>net.minidev</groupId> <artifactId>*</artifactId> </exclusion> <exclusion> <groupId>org.apache.avro</groupId> <artifactId>avro</artifactId> </exclusion> <exclusion> - <groupId>com.google.code.gson</groupId> - <artifactId>gson</artifactId> + <groupId>org.apache.commons</groupId> + <artifactId>commons-compress</artifactId> </exclusion> <exclusion> - <groupId>com.jcraft</groupId> - <artifactId>jsch</artifactId> + <groupId>org.apache.commons</groupId> + <artifactId>commons-lang3</artifactId> + </exclusion> + <!-- commons-cli is required by OzoneFsShell --> Review Comment: Let's move this comment to between `commons-beanutils` and `commons-codec` (where `commons-cli` exclusion would fit). ########## hadoop-hdds/erasurecode/pom.xml: ########## @@ -24,29 +21,27 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> </parent> <artifactId>hdds-erasurecode</artifactId> <version>2.0.0-SNAPSHOT</version> - <description>Apache Ozone Distributed Data Store Earsurecode utils - </description> - <name>Apache Ozone HDDS Erasurecode</name> <packaging>jar</packaging> - - <properties> - <sort.skip>true</sort.skip> - </properties> + <name>Apache Ozone HDDS Erasurecode</name> + <description>Apache Ozone Distributed Data Store Earsurecode utils</description> <dependencies> + <dependency> + <groupId>com.google.guava</groupId> + <artifactId>guava</artifactId> + </dependency> <dependency> <groupId>org.apache.ozone</groupId> <artifactId>hdds-common</artifactId> </dependency> - <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-api</artifactId> </dependency> - <dependency> - <groupId>com.google.guava</groupId> - <artifactId>guava</artifactId> + <groupId>org.apache.ozone</groupId> + <artifactId>hdds-config</artifactId> + <scope>test</scope> </dependency> <!-- Test dependencies --> Review Comment: We can either remove `<!-- Test dependencies -->`, or move it before the first one with test scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
