jojochuang commented on code in PR #7654:
URL: https://github.com/apache/ozone/pull/7654#discussion_r1904963048
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -190,6 +191,13 @@ public KeyValueHandler(ConfigurationSource config,
byteBufferToByteString =
ByteStringConversion
.createByteBufferConversion(isUnsafeByteBufferConversionEnabled);
+
+ if (ContainerLayoutVersion.getConfiguredVersion(conf) ==
+ ContainerLayoutVersion.FILE_PER_CHUNK) {
+ LOG.warn("FILE_PER_CHUNK layout is deprecated. Update to
FILE_PER_BLOCK.");
+
OzoneConfiguration.of(conf).set(ScmConfigKeys.OZONE_SCM_CONTAINER_LAYOUT_KEY,
+ "FILE_PER_BLOCK");
Review Comment:
This PR meant to disallow creating new FILE_PER_CHUNK containers, but it
would still permit reading existing FILE_PER_CHUNK containers.
I'd love to get rid of FILE_PER_CHUNK code altogether but I'm not sure if
anyone still have FILE_PER_CHUNK containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
