adoroszlai commented on code in PR #7656:
URL: https://github.com/apache/ozone/pull/7656#discussion_r1905058398
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -481,16 +481,12 @@ public void setDataStreamBufferFlushSize(long
dataStreamBufferFlushSize) {
this.dataStreamBufferFlushSize = dataStreamBufferFlushSize;
}
- public ChecksumCombineMode getChecksumCombineMode() {
- try {
- return ChecksumCombineMode.valueOf(checksumCombineMode);
- } catch (IllegalArgumentException iae) {
- LOG.warn("Bad checksum combine mode: {}. Using default {}",
- checksumCombineMode,
- ChecksumCombineMode.COMPOSITE_CRC.name());
- return ChecksumCombineMode.valueOf(
- ChecksumCombineMode.COMPOSITE_CRC.name());
Review Comment:
Why don't we return `null` here instead of duplicating validation logic in
callers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
