sumitagrawl commented on code in PR #7602:
URL: https://github.com/apache/ozone/pull/7602#discussion_r1905082198
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java:
##########
@@ -140,12 +140,15 @@ public void handleRequestFailure(OzoneManager
ozoneManager) {
*
* @return the response that will be returned to the client.
*/
- public abstract OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIndex termIndex);
+ public abstract OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, ExecutionContext context);
/** For testing only. */
@VisibleForTesting
public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
long transactionLogIndex) {
- return validateAndUpdateCache(ozoneManager,
TransactionInfo.getTermIndex(transactionLogIndex));
+ ExecutionContext context = new ExecutionContext();
+ context.setTermIndex(TransactionInfo.getTermIndex(transactionLogIndex));
+ context.setIndex(transactionLogIndex);
Review Comment:
yes,
ratis index is used in upgrade prepare and snapshot flow for specific
purpose -- comparing if flush is completed or not.
Default, will be using OM managed index (non-ratis).
Once if removed ratis index in above cases with new flow, will remove this
parameter in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
