adoroszlai commented on code in PR #6898:
URL: https://github.com/apache/ozone/pull/6898#discussion_r1905123229
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java:
##########
@@ -446,6 +447,11 @@ private void loadSSLConfiguration() throws IOException {
excludeCiphers = sslConf.get(SSLFactory.SSL_SERVER_EXCLUDE_CIPHER_LIST);
}
+ public Builder withoutDefaultApps() {
Review Comment:
Changing to `withDefaultApps` would imply the default apps are disabled by
default, since they need to be explicitly enabled by calling the method. They
wouldn't be default apps anymore. Then we'd need to rename `addDefaultApps` to
something like `addExtraApps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
