adoroszlai commented on code in PR #7660: URL: https://github.com/apache/ozone/pull/7660#discussion_r1906454925
########## hadoop-hdds/interface-client/pom.xml: ########## @@ -143,38 +132,21 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd"> <version>${maven-antrun-plugin.version}</version> <executions> <execution> + <goals> + <goal>run</goal> + </goals> <phase>generate-sources</phase> <configuration> <target> - <replace token="com.google.protobuf" - value="org.apache.ratis.thirdparty.com.google.protobuf" - dir="target/generated-sources/java/org/apache/hadoop/hdds/protocol/datanode/proto"> Review Comment: I find the original format more readable, but the option in `sortpom` to preserve this (`indentAttribute`) is available only in newer versions that do not support Java 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
