xichen01 commented on code in PR #7645:
URL: https://github.com/apache/ozone/pull/7645#discussion_r1907305161
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -689,29 +689,8 @@ public CompletableFuture<?> link(DataStream stream,
LogEntryProto entry) {
final KeyValueStreamDataChannel kvStreamDataChannel =
(KeyValueStreamDataChannel) dataChannel;
-
- final ContainerCommandRequestProto request =
Review Comment:
should we remove `KeyValueStreamDataChannel#putBlockRequest`,
`KeyValueStreamDataChannel#buffers` and related code, if we remove PutBlock
here ?
As I understand it, in order to create the `PutBlockReques`, we keep a
`KeyValueStreamDataChannel#buffers` in memory, which guarantees that the
buffers data will only be written at `close`. If we remove the `PutBlock` here,
do we not need it anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
