errose28 commented on PR #7664: URL: https://github.com/apache/ozone/pull/7664#issuecomment-2578282441
Thanks for adding this @Tejaskriya. I wonder if it would be better to have checkpoint as its own command? This would provide a few potential benefits: - Ability to take a DB checkpoint for uses outside the LDB tools itself - No need to add `--checkpoint` to every other command that may need it (FSO repair in debug mode comes to mind) - User explicitly provides a file name so they know where the checkpoint is and that it is safe to remove. Terminal output tends to get lost with history. I'm thinking something like `ozone debug ldb checkpoint --db=<path-to-db> --output=<new-db-dir>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
