adoroszlai commented on code in PR #7653:
URL: https://github.com/apache/ozone/pull/7653#discussion_r1907592121
##########
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/repair/om/TestTransactionInfoRepair.java:
##########
@@ -125,12 +126,14 @@ private void testCommand(ManagedRocksDB mdb,
ColumnFamilyHandle columnFamilyHand
.thenReturn(transactionInfo2);
CommandLine cli = new OzoneRepair().getCmd();
- cli.execute(
- "om",
- "update-transaction",
- "--db", DB_PATH,
- "--term", String.valueOf(TEST_TERM),
- "--index", String.valueOf(TEST_INDEX));
+ withTextFromSystemIn("y")
Review Comment:
It's for test only.
Adding as dependency and copying/reimplementing it both have benefits and
drawbacks. E.g.:
- (+) It has test coverage that I will not add if I need to implement it
from scratch.
- (-) I wish it would allow lambdas with return type, to avoid the need for
the `AtomicInteger` for catching exit code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
