ArafatKhan2198 commented on code in PR #7667:
URL: https://github.com/apache/ozone/pull/7667#discussion_r1909857220
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/select/multiSelect.tsx:
##########
@@ -61,7 +61,8 @@ const Option: React.FC<OptionProps<Option, true>> = (props)
=> {
marginRight: '8px',
accentColor: '#1AA57A'
}}
- onChange={() => null} />
Review Comment:
Will this change be available for other tables as well?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/datanodes/datanodes.tsx:
##########
@@ -294,17 +294,17 @@ const Datanodes: React.FC<{}> = () => {
onCancel={handleModalCancel}
closable={false}
width={400} >
- <div style={{
- margin: '0px 0px 5px 0px',
- fontSize: '16px',
- fontWeight: 'bold'
- }}
+ <div style={{
+ margin: '0px 0px 5px 0px',
+ fontSize: '16px',
+ fontWeight: 'bold'
+ }}
data-testid='dn-remove-modal'>
- <WarningFilled className='icon-warning' style={{paddingRight:
'8px'}}/>
- Stop Tracking Datanode
+ <WarningFilled className='icon-warning' style={{paddingRight:
'8px'}}/>
+ Stop Tracking Datanode
</div>
Are you sure, you want recon to stop tracking the selected
<strong>{selectedRows.length}</strong> datanode(s)?
- </Modal>
Review Comment:
Do we need these changes in the patch?
It seems to be just an extra space added for each line.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/datanodes/datanodes.tsx:
##########
@@ -283,7 +283,7 @@ const Datanodes: React.FC<{}> = () => {
searchColumn={searchColumn}
searchTerm={debouncedSearch}
handleSelectionChange={handleSelectionChange}
- decommissionUuids={decommissionUuids}/>
Review Comment:
Same for this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
