adoroszlai commented on code in PR #122:
URL: https://github.com/apache/ozone-site/pull/122#discussion_r1909924640


##########
docs/02-quick-start/01-installation/01-docker.md:
##########
@@ -2,6 +2,84 @@
 sidebar_label: Docker
 ---
 
+<!-- cspell:words xzf -->
+
 # Try Ozone With Docker
 
-**TODO:** File a subtask under 
[HDDS-9856](https://issues.apache.org/jira/browse/HDDS-9856) and complete this 
page or section.
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+This guide explains how to run Apache Ozone using Docker Compose, either with 
locally built sources or pre-built images.
+
+## Prerequisites
+
+- [Docker Engine](https://www.docker.com/products/docker-desktop/) 20.10.0 or 
higher

Review Comment:
   - The bug, reported few months ago, is present in Docker Compose 
`2.29.[3..)`, fixed in 2.30.  Docker Engine 27.4.0 is the first version to 
include Compose 2.30+.
   - Docker Engine 
[20.10.0](https://docs.docker.com/engine/release-notes/20.10/#20100) was 
released 2020-12-08.
   - Docker Engine 
[2.10.13](https://docs.docker.com/engine/release-notes/20.10/#201013) was the 
first version to include Compose v2 as a plugin.
   - Support for dash in variable name was introduced sometime in 2023 
(https://github.com/compose-spec/compose-go/commit/be170befda31a336a94d248ac1221fceeac834c8).
   
   So I don't think 2.10.0 would work.
   
   We should probably omit version numbers.  Maybe add a note that some 
versions may have this problem, and instruct users to upgrade to the latest 
versions if they encounter it.
   
   Let's also omit V2 (for Docker Compose), too, since V1 works fine (but is 
deprecated).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to