sarvekshayr commented on PR #7689: URL: https://github.com/apache/ozone/pull/7689#issuecomment-2586507403
> I would like to avoid copying logic for SCM's version of the tool. Here's my attempt to reduce duplication: [adoroszlai@29fd408](https://github.com/adoroszlai/ozone/commit/29fd4080b5efe9e3a8be7a6343d02a66e21c2c80), which results in smaller diff: [master...adoroszlai:ozone:HDDS-12050](https://github.com/apache/ozone/compare/master...adoroszlai:ozone:HDDS-12050) Thank you @adoroszlai. The change proposed is simpler, reduces duplication and the patch looks good overall. We can commit the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
