ptlrs commented on PR #7693: URL: https://github.com/apache/ozone/pull/7693#issuecomment-2593559615
Thank you for the reivew @adoroszlai. I had the same thought of replacing `/` with `_` in key names while I was implementing this change. However, I didn't do it because of potential key name conflicts. For example, Key `rmp/1` will be converted to `rmp_1` Key `rmp_1` will remain as `rmp_1`. While we do use a timestamp suffix to allow multiple runs of `read-replicas` with the key same name, there is an ambiguity introduced here. We can't readily `grep` for or reconstruct the original key name from the generated name. We may need to check the contents of the generated manifest file. Is this a significant inconvenience? If not, then I can make this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
