elek commented on a change in pull request #2068:
URL: https://github.com/apache/ozone/pull/2068#discussion_r604656692
##########
File path: hadoop-hdds/interface-server/src/main/proto/ScmServerProtocol.proto
##########
@@ -132,9 +132,13 @@ message AllocateScmBlockRequestProto {
required uint64 size = 1;
required uint32 numBlocks = 2;
required ReplicationType type = 3;
- required hadoop.hdds.ReplicationFactor factor = 4;
+ optional hadoop.hdds.ReplicationFactor factor = 4;
Review comment:
> Would an old client which has it set to required, complain if it
received a message missing the field?
Good question and I agree that it should be OK. This field will always be
filled for STANDALONE / RATIS. Old clients remain compatible as long as they
use only existing replication types. It is optional only for EC where we need
an exception from the old client anyway, as old client couldn't use new
replication types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
