errose28 commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1924577640
########## hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java: ########## @@ -70,6 +70,7 @@ import static org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ContainerDataProto.State.UNHEALTHY; import static org.apache.hadoop.hdds.scm.ScmConfigKeys.HDDS_DATANODE_DIR_KEY; import static org.apache.hadoop.ozone.OzoneConsts.GB; +import static org.apache.hadoop.ozone.container.checksum.ContainerMerkleTreeTestUtils.createBlockMetaData; Review Comment: Other things to test here are that bytes used and block count metadata fields are updated accordingly, and that simultaneous scan and reconcile of a container do not conflict. As long as we are writing the data before the metadata the scanner should not have an issue, because it uses the metadata as the source of truth for what should be in the container. The scanner may get a partial view of the container as it is being repaired but this is ok as long as the tree is not inconsistent and it is not incorrectly marked unhealthy. The tree will be fully updated on the next scanner run or reconcile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
