avijayanhwx commented on a change in pull request #2098:
URL: https://github.com/apache/ozone/pull/2098#discussion_r605256319
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServer.java
##########
@@ -45,7 +46,7 @@ SCMRatisResponse submitRequest(SCMRatisRequest request)
/**
* Returns roles of ratis peers.
*/
- List<String> getRatisRoles();
+ List<String> getRatisRoles() throws UnknownHostException;
Review comment:
nit. Good to through "IOException" here, rather than an implementation
detail like UnknownHostException.
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/scmha.robot
##########
@@ -25,4 +25,4 @@ Test Timeout 5 minutes
*** Test Cases ***
Run scm roles
${output} = Execute ozone admin scm roles
- Should contain ${output} [scm:9865]
+ Should Match Regexp ${output}
[scm:9865:(LEADER|FOLLOWER)]
Review comment:
Is it possible to verify that we have 1 LEADER & 2 FOLLOWER strings in
the response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
