[
https://issues.apache.org/jira/browse/HDDS-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923387#comment-17923387
]
Ivan Andika edited comment on HDDS-12047 at 2/3/25 5:14 PM:
------------------------------------------------------------
> I’m planning to merge the tests into TestOzoneClientMultipartUpload, and I’ve
> noticed that there are quite a few tests that need to be moved. Would it be
> better to separate them into multiple PRs?
Each PR requires a single ticket so I'm fine if you can divide them to multiple
tickets for each task. Otherwise, I think we can simply have a well-formed PR
where each commit handles a part of the refactoring.
> I was thinking that for the first PR, I could move all the Copy tests from
> TestOzoneClientMultipartUploadWithFSO to TestOzoneClientMultipartUpload and
> apply the bucketLayout parameterized test on them. Does that approach sound
> reasonable?
Which "Copy" tests in TestOzoneClientMultipartUploadWithFSO are you referring
to? I can't seem to find them.
Do you mean to just rename the TestOzoneClientMultipartUploadWithFSO to
TestOzoneClientMultipartUpload and add the bucket layout parameterization?
was (Author: JIRAUSER298977):
> I’m planning to merge the tests into TestOzoneClientMultipartUpload, and I’ve
> noticed that there are quite a few tests that need to be moved. Would it be
> better to separate them into multiple PRs?
Each PR requires a single ticket so I'm fine if you can divide them to multiple
tickets for each task. Otherwise, I think we can simply have a well-formed PR
where each commit handles a part of the refactoring.
> I was thinking that for the first PR, I could move all the Copy tests from
> TestOzoneClientMultipartUploadWithFSO to TestOzoneClientMultipartUpload and
> apply the bucketLayout parameterized test on them. Does that approach sound
> reasonable?
Which "Copy" tests in TestOzoneClientMultipartUploadWithFSO are you referring
to? I can't seem to find them.
Do you mean to just rename the TestOzoneClientMultipartUploadWithFSO to
TestOzoneClientMultipartUploadWith and add the bucket layout parameterization?
> Merge TestOzoneClientMultipartUploadWithFSO to OzoneRpcClientTests
> ------------------------------------------------------------------
>
> Key: HDDS-12047
> URL: https://issues.apache.org/jira/browse/HDDS-12047
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Ivan Andika
> Assignee: Peter Lee
> Priority: Major
>
> TestOzoneClientMultipartUploadWithFSO contains a lot general MPU tests
> although the test class was intended for FSO. It also contains some
> duplicates with OzoneRpcClientTests (e.g.
> testMultipartUploadWithPartsLessThanMinSize). There are cases where MPU
> related patches only added test cases to
> TestOzoneClientMultipartUploadWithFSO but not OzoneRpcClientTests
> It's better to merge the tests to OzoneRpcClientTests since it supports
> BucketLayout parameterization so that the tests do not need to build a new
> MiniOzoneCluster for each BucketLayout tests and also ensure that new MPU
> features are tested in both bucket layout.
> For bucket layout specific tests, we can simply use Assumptions.assumeTrue to
> only run the test if the bucket layout is correct.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
