fapifta commented on code in PR #6932: URL: https://github.com/apache/ozone/pull/6932#discussion_r1933354617
########## hadoop-hdds/annotations/src/main/java/org/apache/ozone/annotations/OmRequestFeatureValidatorProcessor.java: ########## Review Comment: I kind of disagree here still... In the actual codebase, you can not specify a version that is not part of the enum already as you use the enum. To define a future version validator correctly, you need to see into the future, which does not seem to be possibile. So, even though it is probably not something one would do, but I think we may validate that at compile time. I accept if we don't, but the only invalid value that can be specified is the FUTURE_VERSION as of now, so why not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
