[
https://issues.apache.org/jira/browse/HDDS-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923910#comment-17923910
]
Venkat Sambath commented on HDDS-12194:
---------------------------------------
I tested in 1.4.1 and I no longer see the ambiguous logging.
1.4.1 logs looks like below.
{code:java}
2025-02-04 22:59:32,091 INFO snapshot.OMSnapshotCreateRequest
(OMSnapshotCreateRequest.java:validateAndUpdateCache(219)) - Created snapshot:
'snap1' with snapshotId: '28437cb2-6bc9-499c-87c3-8f3d79e94841' under path
'vol1/bucket1'
2025-02-04 22:59:45,087 INFO snapshot.OMSnapshotSetPropertyRequest
(OMSnapshotSetPropertyRequest.java:validateAndUpdateCache(105)) - Successfully
executed snapshotSetPropertyRequest: {snapshotKey: "/vol1/bucket1/snap1"
deepCleanedDeletedKey: true
}.
{code}
We are good to resolve this issue.
> Distinguish update/purge snapshot
> ---------------------------------
>
> Key: HDDS-12194
> URL: https://issues.apache.org/jira/browse/HDDS-12194
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Venkat Sambath
> Priority: Minor
>
> Currently when snapshot is created/deleted in ozone-ha env, ozone-om logs
> indicates it as "Successfully executed snapshotPurgeRequest" - Can this
> logging be changed to distinguish purge vs update?
> 2025-02-03 22:40:16,958 INFO snapshot.OMSnapshotCreateRequest
> (OMSnapshotCreateRequest.java:validateAndUpdateCache(195)) - Created
> snapshot: 'snap4' with snapshotId: 'c65e08d2-6a76-440b-9cb8-b8682cbef305'
> under path 'vol1/bucket1'
> ..
> 2025-02-03 22:40:42,990 INFO snapshot.OMSnapshotPurgeRequest
> (OMSnapshotPurgeRequest.java:validateAndUpdateCache(141)) - Successfully
> executed snapshotPurgeRequest: {updatedSnapshotDBKey: "/vol1/bucket1/snap4"
> } along with updating snapshots:{/vol1/bucket1/snap4=SnapshotInfo{snapshotId:
> 'c65e08d2-6a76-440b-9cb8-b8682cbef305', name: 'snap4', volumeName: 'vol1',
> bucketName: 'bucket1', snapshotStatus: 'SNAPSHOT_ACTIVE', creationTime:
> '1738640416889', deletionTime: '-1', pathPreviousSnapshotId:
> '91eb2bc2-3dff-44ea-94e9-3b76d2cb9ad0', globalPreviousSnapshotId:
> '91eb2bc2-3dff-44ea-94e9-3b76d2cb9ad0', snapshotPath: 'vol1/bucket1',
> checkpointDir: '-c65e08d2-6a76-440b-9cb8-b8682cbef305', dbTxSequenceNumber:
> '22', deepClean: 'false', sstFiltered: 'false'}}.
> And if you delete snapshot it prints
> 2025-02-03 22:43:12,751 INFO snapshot.OMSnapshotPurgeRequest
> (OMSnapshotPurgeRequest.java:validateAndUpdateCache(141)) - Successfully
> executed snapshotPurgeRequest: {snapshotDBKeys: "/vol1/bucket1/snap4"
> } along with updating snapshots:{/vol1/bucket1/snap4=SnapshotInfo{snapshotId:
> 'c65e08d2-6a76-440b-9cb8-b8682cbef305', name: 'snap4', volumeName: 'vol1',
> bucketName: 'bucket1', snapshotStatus: 'SNAPSHOT_DELETED', creationTime:
> '1738640416889', deletionTime: '1738640583682', pathPreviousSnapshotId:
> '91eb2bc2-3dff-44ea-94e9-3b76d2cb9ad0', globalPreviousSnapshotId:
> '91eb2bc2-3dff-44ea-94e9-3b76d2cb9ad0', snapshotPath: 'vol1/bucket1',
> checkpointDir: '-c65e08d2-6a76-440b-9cb8-b8682cbef305', dbTxSequenceNumber:
> '22', deepClean: 'false', sstFiltered: 'false'}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
