adoroszlai commented on code in PR #7805:
URL: https://github.com/apache/ozone/pull/7805#discussion_r1943675167
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java:
##########
@@ -280,6 +280,29 @@ public static SCMRegisteredResponseProto
getRegisteredResponse(
return cmd.getProtoBufMessage();
}
+ private String constructCommandAuditMap(List<SCMCommandProto> cmds) {
+ StringBuilder auditMap = new StringBuilder();
+ auditMap.append("[");
+ for (SCMCommandProto cmd : cmds) {
+ if (cmd.getCommandType().equals(deleteBlocksCommand)) {
+ auditMap.append("commandType: ").append(cmd.getCommandType());
+ auditMap.append(" deleteTransactionsCount:");
+
auditMap.append(cmd.getDeleteBlocksCommandProto().getDeletedBlocksTransactionsList().size());
+ } else {
+ auditMap.append(cmd);
+ }
+ auditMap.append(" , ");
Review Comment:
```suggestion
auditMap.append(", ");
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java:
##########
@@ -280,6 +280,29 @@ public static SCMRegisteredResponseProto
getRegisteredResponse(
return cmd.getProtoBufMessage();
}
+ private String constructCommandAuditMap(List<SCMCommandProto> cmds) {
+ StringBuilder auditMap = new StringBuilder();
+ auditMap.append("[");
+ for (SCMCommandProto cmd : cmds) {
+ if (cmd.getCommandType().equals(deleteBlocksCommand)) {
+ auditMap.append("commandType: ").append(cmd.getCommandType());
+ auditMap.append(" deleteTransactionsCount:");
+
auditMap.append(cmd.getDeleteBlocksCommandProto().getDeletedBlocksTransactionsList().size());
+ } else {
+ auditMap.append(cmd);
+ }
+ auditMap.append(" , ");
+ }
+ int len = auditMap.toString().length();
Review Comment:
Let's not call `toString()` twice.
```suggestion
int len = auditMap.length();
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java:
##########
@@ -280,6 +280,29 @@ public static SCMRegisteredResponseProto
getRegisteredResponse(
return cmd.getProtoBufMessage();
}
+ private String constructCommandAuditMap(List<SCMCommandProto> cmds) {
+ StringBuilder auditMap = new StringBuilder();
+ auditMap.append("[");
+ for (SCMCommandProto cmd : cmds) {
+ if (cmd.getCommandType().equals(deleteBlocksCommand)) {
+ auditMap.append("commandType: ").append(cmd.getCommandType());
+ auditMap.append(" deleteTransactionsCount:");
+
auditMap.append(cmd.getDeleteBlocksCommandProto().getDeletedBlocksTransactionsList().size());
+ } else {
+ auditMap.append(cmd);
+ }
+ auditMap.append(" , ");
+ }
+ int len = auditMap.toString().length();
+ if (len > 3) {
+ auditMap.deleteCharAt(len - 1);
+ auditMap.deleteCharAt(len - 2);
+ auditMap.deleteCharAt(len - 3);
+ }
Review Comment:
I think this can be simplified.
(3 should be 2 if ` ,` is changed to `, `.)
```suggestion
if (len > 3) {
auditMap.delete(len - 3, len);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
