kerneltime commented on PR #7708:
URL: https://github.com/apache/ozone/pull/7708#issuecomment-2645513610

   > I looked at communication in Hadoop(mailing lists) and discussion and 
realization can take a long time ) I think the best way is not to depend on 
Hadoop libraries and change the metric library to another instead of improving 
the Hadoop metric library. I offer to close this PR and create one task to 
change the metric library and (I'm not sure) another to create an Ozone metric 
API which can be implemented by any metric library. What's your opinion, 
@adoroszlai ?
   
   If we are to replace the metric implementation, I would go with something 
like [dropwizard](https://metrics.dropwizard.io/4.2.0/) or another existing 
package to reuse after comparing performance. 
   
   > @kerneltime The desired impact is to get rid of the locks in metrics 
collecting and improve writing speed. Without a fix, it was a 3000-3200 writing 
operation (CreateFile or CommitKey). After fixing it was 3600-3700. Improvement 
of more than 12%.
   
   This is a decent improvement, @adoroszlai should we initiate an upstream 
discussion with Hadoop while we see if we can merge this change in. I think we 
need a dual strategy
   
   1. Evaluate a replacement for Hadoop metrics
   2. Start a PR upstream with Hadoop while we move Ozone to use the more 
performant solution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to