ashishkumar50 commented on code in PR #7830:
URL: https://github.com/apache/ozone/pull/7830#discussion_r1948609664
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java:
##########
@@ -220,12 +220,16 @@ public void checkAllVolumes(StorageVolumeChecker checker)
Set<? extends StorageVolume> failedVolumes;
try {
failedVolumes = checker.checkAllVolumes(allVolumes);
+ if (failedVolumes.size() > 0) {
+ LOG.warn("checkAllVolumes got {} failed volumes - {}",
+ failedVolumes.size(), failedVolumes);
+ }
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Interrupted while running disk check", e);
}
- if (failedVolumes.size() > 0) {
+ if (failedVolumeMap.size() > 0 || failedVolumes.size() > 0) {
Review Comment:
Log i have moved up, removed duplicate log.
We need to check `failedVolumeMap` size as well here, as this is filled from
other part of code as well. `hasEnoughVolumes` inside `handleVolumeFailures`
checks whether there are enough volume in system to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
