adoroszlai commented on code in PR #5417:
URL: https://github.com/apache/ozone/pull/5417#discussion_r1948677142
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -123,14 +129,19 @@ message Pipeline {
optional ReplicationType type = 3 [default = STAND_ALONE];
optional ReplicationFactor factor = 4 [default = ONE];
required PipelineID id = 5;
+ // TODO: Deprecate this and replace with leaderDnID
optional string leaderID = 6;
repeated uint32 memberOrders = 7;
optional uint64 creationTimeStamp = 8;
+ // TODO: Deprecate this and replace with suggesterLeaderDnID
optional UUID suggestedLeaderID = 9;
repeated uint32 memberReplicaIndexes = 10;
optional ECReplicationConfig ecReplicationConfig = 11;
- // TODO(runzhiwang): when leaderID is gone, specify 6 as the index of
leaderID128
+
optional UUID leaderID128 = 100;
+ // TODO: Replace UUID with DatanodeIDProto
+ optional DatanodeIDProto leaderDnID = 101;
+ optional DatanodeIDProto suggesterLeaderDnID = 102;
Review Comment:
Sorry, I just noticed a typo:
```suggestion
optional DatanodeIDProto leaderDnID = 101;
optional DatanodeIDProto suggestedLeaderDnID = 102;
```
I would also consider expanding `...DnID` to `...DatanodeID`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
