adoroszlai commented on code in PR #7864:
URL: https://github.com/apache/ozone/pull/7864#discussion_r1953916492


##########
hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot:
##########
@@ -131,8 +131,7 @@ Test ozone shell errors
     ${result} =     Execute and checkrc    ozone sh bucket create 
${protocol}${server}/${volume}/bucket1                    255
                     Should contain      ${result}       QUOTA_ERROR
                     Execute and checkrc    ozone sh volume delete 
${protocol}${server}/${volume}                            0
-    ${result} =     Execute and checkrc    ozone sh key put 
${protocol}${server}/${volume}/bucket1/key1 sample.txt          255
-                    Should Match Regexp                    ${result}       
Error: File not found: .*

Review Comment:
   Tests need setup.  If you want to test `key put` and avoid volume/bucket not 
found error, use an existing volume and bucket.
   
   Let's move this test case to `Test key handling`, which is called with an 
existing volume and bucket, near this part:
   
   
https://github.com/apache/ozone/blob/04738af6378e6db1b3f06c48420afc5e70f1f217/hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot#L186-L189



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to