ivanzlenko commented on code in PR #7870:
URL: https://github.com/apache/ozone/pull/7870#discussion_r1958043130
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java:
##########
@@ -33,18 +35,31 @@
import static
org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_FS_LISTING_PAGE_SIZE;
import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_REPLICATION;
import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_REPLICATION_TYPE;
+import static org.apache.hadoop.ozone.OzoneConsts.OZONE_OFS_URI_SCHEME;
+import static org.apache.hadoop.ozone.OzoneConsts.OZONE_URI_SCHEME;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
* Common test cases for Ozone file systems.
*/
-final class OzoneFileSystemTests {
+public final class OzoneFileSystemTests {
Review Comment:
Can we rename this class to something like OzoneFileSystemTestUtils? Right
now it feels like it is a test case rather than collection of utils.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestOmBucketReadWriteFileOps.java:
##########
@@ -243,82 +202,129 @@ private void verifyOMLockMetrics(OMLockMetrics
omLockMetrics) {
assertThat(writeHeldSamples).isPositive();
}
- private static class ParameterBuilder {
+ static class ParameterBuilder {
Review Comment:
Let's move this class into a separate file and name it appropriately to
reduce code clutter in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
