sumitagrawl commented on code in PR #7722: URL: https://github.com/apache/ozone/pull/7722#discussion_r1960084517
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/execution/IndexGenerator.java: ########## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.execution; + +import java.io.IOException; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicLong; +import org.apache.hadoop.hdds.utils.TransactionInfo; +import org.apache.hadoop.hdds.utils.db.BatchOperation; +import org.apache.hadoop.ozone.om.OzoneManager; + +/** + * Context required for execution of a request. + */ +public final class IndexGenerator { + public static final String OM_INDEX_KEY = "#OMINDEX"; + + private final AtomicLong index = new AtomicLong(); + private final AtomicLong commitIndex = new AtomicLong(); + private final OzoneManager ozoneManager; + private final AtomicBoolean enabled = new AtomicBoolean(true); + + public IndexGenerator(OzoneManager ozoneManager) throws IOException { + this.ozoneManager = ozoneManager; + initialize(); + } + + public void initialize() throws IOException { + // default first time starts with "0" + long initIndex = 0; + // retrieve last saved index + TransactionInfo transactionInfo = ozoneManager.getMetadataManager().getTransactionInfoTable().get(OM_INDEX_KEY); + if (null == transactionInfo) { + // use ratis transaction for first time upgrade + transactionInfo = TransactionInfo.readTransactionInfo(ozoneManager.getMetadataManager()); + } + if (null != transactionInfo) { + initIndex = transactionInfo.getTransactionIndex(); + } + index.set(initIndex); + commitIndex.set(initIndex); + if (ozoneManager.getVersionManager().needsFinalization()) { + enabled.set(false); + } + } + + public void finalizeIndexGeneratorFeature() throws IOException { + enabled.set(true); + long initIndex = 0; + TransactionInfo transactionInfo = TransactionInfo.readTransactionInfo(ozoneManager.getMetadataManager()); + if (null != transactionInfo) { + initIndex = transactionInfo.getTransactionIndex(); + } + index.set(initIndex); + commitIndex.set(initIndex); + } + + public long nextIndex() { + if (!enabled.get()) { + return -1; + } + return index.incrementAndGet(); + } + + public void changeLeader() { + index.set(Math.max(commitIndex.get(), index.get())); + } + + public synchronized void saveIndex(BatchOperation batchOperation, long idx) throws IOException { Review Comment: This is synchronized for handling conflict with new flow and existing flow. Existing flow: update in DoubleBuffer thread new flow (not yet present): will be updating on applyTransaction thread. Once Existing flow is removed after all changes, this can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
