nandakumar131 commented on code in PR #7914:
URL: https://github.com/apache/ozone/pull/7914#discussion_r1962043236
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java:
##########
@@ -429,4 +430,14 @@ public RaftPeer getLeader() {
division.getRaftConf().getPeer(RaftPeerId.valueOf(leaderId));
}
}
+
+ @Override
+ @SuppressWarnings("unchecked")
+ public <T> T getProxyHandler(final RequestType type, final Class<T> intf,
final T impl) {
+ final SCMHAInvocationHandler invocationHandler =
+ new SCMHAInvocationHandler(type, impl, this);
+ return (T) Proxy.newProxyInstance(getClass().getClassLoader(),
+ new Class<?>[] {intf}, invocationHandler);
+ }
Review Comment:
Thanks @adoroszlai for the detailed review.
I somehow missed `FinalizationStateManagerImpl`, `SCMCertStore` &
`ScmSecretKeyStateBuilder`, thanks for catching them.
Addressed all the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
