[
https://issues.apache.org/jira/browse/HDDS-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-12347:
------------------------------------
Description:
{code}
M D NP: Possible null pointer dereference in
org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.testCopyDirectoryWithDelete()
due to return value of called method Dereferenced at
AbstractContractCopyFromLocalTest.java:[line 265]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.teardown() At
AbstractContractCopyFromLocalTest.java:[line 50]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.testCopyMissingFile()
At AbstractContractCopyFromLocalTest.java:[line 102]
M D BC: Unchecked/unconfirmed cast from org.apache.hadoop.fs.FileStatus to
org.apache.hadoop.fs.EtagSource in
org.apache.hadoop.fs.contract.AbstractContractEtagTest.etagFromStatus(FileStatus)
At AbstractContractEtagTest.java:[line 86]
M B RR:
org.apache.hadoop.fs.ozone.TestOzoneFSWithObjectStoreCreate.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
TestOzoneFSWithObjectStoreCreate.java:[line 439]
M B RR:
org.apache.hadoop.fs.ozone.TestOzoneFSWithObjectStoreCreate.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestOzoneFSWithObjectStoreCreate.java:[line 430]
M D NP: Possible null pointer dereference in
org.apache.hadoop.hdds.scm.TestSCMInstallSnapshot.testInstallCheckPoint() due
to return value of called method Dereferenced at
TestSCMInstallSnapshot.java:[line 129]
M D NP: Possible null pointer dereference in
org.apache.hadoop.hdds.scm.TestSCMInstallSnapshotWithHA.testInstallCorruptedCheckpointFailure()
due to return value of called method Dereferenced at
TestSCMInstallSnapshotWithHA.java:[line 243]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.hdds.scm.TestSCMInstallSnapshotWithHA.testInstallCorruptedCheckpointFailure()
At TestSCMInstallSnapshotWithHA.java:[line 247]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.hdds.scm.TestStorageContainerManagerHA.testBootStrapSCM() At
TestStorageContainerManagerHA.java:[line 277]
M D DLS: Dead store to container2 in
org.apache.hadoop.hdds.scm.container.TestContainerStateManagerIntegration.testAllocateContainerWithDifferentOwner()
At TestContainerStateManagerIntegration.java:[line 138]
M D NP: Possible null pointer dereference in
org.apache.hadoop.ozone.om.TestKeyManagerImpl.verifyFileStatus(String, List,
Set, Set, boolean) due to return value of called method Dereferenced at
TestKeyManagerImpl.java:[line 1669]
M B RR: org.apache.hadoop.ozone.om.TestListKeys.createKey(OzoneBucket, String,
int, byte[]) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestListKeys.java:[line 395]
M B RR: org.apache.hadoop.ozone.om.TestListKeysWithFSO.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestListKeysWithFSO.java:[line 667]
M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet.prepSnapshotData() At
TestOMDbCheckpointServlet.java:[line 693]
M D NP: Possible null pointer dereference in
org.apache.hadoop.ozone.om.TestOMRatisSnapshots.checkSnapshot(OzoneManager,
OzoneManager, String, List, SnapshotInfo) due to return value of called method
Dereferenced at TestOMRatisSnapshots.java:[line 356]
M D NP: Possible null pointer dereference in
org.apache.hadoop.ozone.om.TestOMRatisSnapshots.testInstallCorruptedCheckpointFailure()
due to return value of called method Dereferenced at
TestOMRatisSnapshots.java:[line 1015]
M D NP: Possible null pointer dereference in
org.apache.hadoop.ozone.om.TestOMRatisSnapshots.unTarLatestTarBall(OzoneManager,
Path) due to return value of called method Method invoked at
TestOMRatisSnapshots.java:[line 1118]
M B RR: org.apache.hadoop.ozone.om.TestOMRatisSnapshots.readKeys(List) ignores
result of org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int,
int) At TestOMRatisSnapshots.java:[line 1100]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.ozone.om.TestOMRatisSnapshots.testInstallCorruptedCheckpointFailure()
At TestOMRatisSnapshots.java:[line 1019]
M B RR:
org.apache.hadoop.ozone.om.TestObjectStoreWithFSO.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
TestObjectStoreWithFSO.java:[line 601]
M B RR:
org.apache.hadoop.ozone.om.TestObjectStoreWithFSO.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestObjectStoreWithFSO.java:[line 588]
M D RV: Return value of OMMetadataManager.getBucketTable() ignored, but method
has no side effect At TestOmMetrics.java:[line 665]
M D RV: Return value of OMMetadataManager.getVolumeTable() ignored, but method
has no side effect At TestOmMetrics.java:[line 667]
M B RR: org.apache.hadoop.ozone.om.TestOzoneManagerHA.createKeyTest(boolean)
ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
TestOzoneManagerHA.java:[line 433]
M B RR:
org.apache.hadoop.ozone.om.TestOzoneManagerHA.testCreateFile(OzoneBucket,
String, String, boolean, boolean) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
TestOzoneManagerHA.java:[line 381]
M D DLS: Dead store to followerOM2 in
org.apache.hadoop.ozone.om.TestOzoneManagerHAWithStoppedNodes.testOMRestart()
At TestOzoneManagerHAWithStoppedNodes.java:[line 278]
M B RR:
org.apache.hadoop.ozone.om.TestOzoneManagerHAWithStoppedNodes.createMultipartKeyAndReadKey(OzoneBucket,
String, String) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
TestOzoneManagerHAWithStoppedNodes.java:[line 223]
M B RR:
org.apache.hadoop.ozone.om.snapshot.TestOmSnapshot.checkDayWeekMonthSnapshotData(OzoneBucket,
int, int, int, int, int, int) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
TestOmSnapshot.java:[line 2341]
M B RR:
org.apache.hadoop.ozone.om.snapshot.TestOmSnapshot.validateSnapshotDataIntegrity(String,
int, int, OzoneBucket) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
TestOmSnapshot.java:[line 2380]
M B RR:
org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystem.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
TestOmSnapshotFileSystem.java:[line 387]
M B RR:
org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystem.createKey(OzoneBucket,
String, int, byte[]) ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestOmSnapshotFileSystem.java:[line 374]
M B RR:
org.apache.hadoop.ozone.om.snapshot.TestSnapshotBackgroundServices.readKeys(List)
ignores result of
org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
TestSnapshotBackgroundServices.java:[line 663]
M D RV: Return value of SnapshotDiffManager.isKeyInBucket(String, Map, String)
ignored, but method has no side effect At TestSnapshotDiffManager.java:[line
688]
M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
org.apache.hadoop.ozone.shell.TestOzoneShellHA.startCluster(OzoneConfiguration)
At TestOzoneShellHA.java:[line 187]
M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.ozone.shell.TestOzoneShellHA.startCluster(OzoneConfiguration)
At TestOzoneShellHA.java:[line 186]
M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
TestOzoneTenantShell.java:[line 140]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
TestOzoneTenantShell.java:[line 121]
M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
TestOzoneTenantShell.java:[line 139]
M B RV: Exceptional return value of java.io.File.delete() ignored in
org.apache.hadoop.ozone.shell.TestOzoneTenantShell.shutdown() At
TestOzoneTenantShell.java:[line 166]
M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
org.apache.hadoop.ozone.shell.TestReplicationConfigPreference.init() At
TestReplicationConfigPreference.java:[line 100]
M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.ozone.shell.TestReplicationConfigPreference.init() At
TestReplicationConfigPreference.java:[line 99]
{code}
> Fix spotbugs warnings in integration tests
> ------------------------------------------
>
> Key: HDDS-12347
> URL: https://issues.apache.org/jira/browse/HDDS-12347
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
>
> {code}
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.testCopyDirectoryWithDelete()
> due to return value of called method Dereferenced at
> AbstractContractCopyFromLocalTest.java:[line 265]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.teardown()
> At AbstractContractCopyFromLocalTest.java:[line 50]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.fs.contract.AbstractContractCopyFromLocalTest.testCopyMissingFile()
> At AbstractContractCopyFromLocalTest.java:[line 102]
> M D BC: Unchecked/unconfirmed cast from org.apache.hadoop.fs.FileStatus to
> org.apache.hadoop.fs.EtagSource in
> org.apache.hadoop.fs.contract.AbstractContractEtagTest.etagFromStatus(FileStatus)
> At AbstractContractEtagTest.java:[line 86]
> M B RR:
> org.apache.hadoop.fs.ozone.TestOzoneFSWithObjectStoreCreate.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
> TestOzoneFSWithObjectStoreCreate.java:[line 439]
> M B RR:
> org.apache.hadoop.fs.ozone.TestOzoneFSWithObjectStoreCreate.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestOzoneFSWithObjectStoreCreate.java:[line 430]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.hdds.scm.TestSCMInstallSnapshot.testInstallCheckPoint() due
> to return value of called method Dereferenced at
> TestSCMInstallSnapshot.java:[line 129]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.hdds.scm.TestSCMInstallSnapshotWithHA.testInstallCorruptedCheckpointFailure()
> due to return value of called method Dereferenced at
> TestSCMInstallSnapshotWithHA.java:[line 243]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.hdds.scm.TestSCMInstallSnapshotWithHA.testInstallCorruptedCheckpointFailure()
> At TestSCMInstallSnapshotWithHA.java:[line 247]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.hdds.scm.TestStorageContainerManagerHA.testBootStrapSCM()
> At TestStorageContainerManagerHA.java:[line 277]
> M D DLS: Dead store to container2 in
> org.apache.hadoop.hdds.scm.container.TestContainerStateManagerIntegration.testAllocateContainerWithDifferentOwner()
> At TestContainerStateManagerIntegration.java:[line 138]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.ozone.om.TestKeyManagerImpl.verifyFileStatus(String, List,
> Set, Set, boolean) due to return value of called method Dereferenced at
> TestKeyManagerImpl.java:[line 1669]
> M B RR: org.apache.hadoop.ozone.om.TestListKeys.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestListKeys.java:[line 395]
> M B RR: org.apache.hadoop.ozone.om.TestListKeysWithFSO.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestListKeysWithFSO.java:[line 667]
> M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
> org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet.prepSnapshotData() At
> TestOMDbCheckpointServlet.java:[line 693]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.ozone.om.TestOMRatisSnapshots.checkSnapshot(OzoneManager,
> OzoneManager, String, List, SnapshotInfo) due to return value of called
> method Dereferenced at TestOMRatisSnapshots.java:[line 356]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.ozone.om.TestOMRatisSnapshots.testInstallCorruptedCheckpointFailure()
> due to return value of called method Dereferenced at
> TestOMRatisSnapshots.java:[line 1015]
> M D NP: Possible null pointer dereference in
> org.apache.hadoop.ozone.om.TestOMRatisSnapshots.unTarLatestTarBall(OzoneManager,
> Path) due to return value of called method Method invoked at
> TestOMRatisSnapshots.java:[line 1118]
> M B RR: org.apache.hadoop.ozone.om.TestOMRatisSnapshots.readKeys(List)
> ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestOMRatisSnapshots.java:[line 1100]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.ozone.om.TestOMRatisSnapshots.testInstallCorruptedCheckpointFailure()
> At TestOMRatisSnapshots.java:[line 1019]
> M B RR:
> org.apache.hadoop.ozone.om.TestObjectStoreWithFSO.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
> TestObjectStoreWithFSO.java:[line 601]
> M B RR:
> org.apache.hadoop.ozone.om.TestObjectStoreWithFSO.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestObjectStoreWithFSO.java:[line 588]
> M D RV: Return value of OMMetadataManager.getBucketTable() ignored, but
> method has no side effect At TestOmMetrics.java:[line 665]
> M D RV: Return value of OMMetadataManager.getVolumeTable() ignored, but
> method has no side effect At TestOmMetrics.java:[line 667]
> M B RR: org.apache.hadoop.ozone.om.TestOzoneManagerHA.createKeyTest(boolean)
> ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
> TestOzoneManagerHA.java:[line 433]
> M B RR:
> org.apache.hadoop.ozone.om.TestOzoneManagerHA.testCreateFile(OzoneBucket,
> String, String, boolean, boolean) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
> TestOzoneManagerHA.java:[line 381]
> M D DLS: Dead store to followerOM2 in
> org.apache.hadoop.ozone.om.TestOzoneManagerHAWithStoppedNodes.testOMRestart()
> At TestOzoneManagerHAWithStoppedNodes.java:[line 278]
> M B RR:
> org.apache.hadoop.ozone.om.TestOzoneManagerHAWithStoppedNodes.createMultipartKeyAndReadKey(OzoneBucket,
> String, String) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
> TestOzoneManagerHAWithStoppedNodes.java:[line 223]
> M B RR:
> org.apache.hadoop.ozone.om.snapshot.TestOmSnapshot.checkDayWeekMonthSnapshotData(OzoneBucket,
> int, int, int, int, int, int) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
> TestOmSnapshot.java:[line 2341]
> M B RR:
> org.apache.hadoop.ozone.om.snapshot.TestOmSnapshot.validateSnapshotDataIntegrity(String,
> int, int, OzoneBucket) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[]) At
> TestOmSnapshot.java:[line 2380]
> M B RR:
> org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystem.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.fs.FSDataInputStream.read(byte[], int, int) At
> TestOmSnapshotFileSystem.java:[line 387]
> M B RR:
> org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystem.createKey(OzoneBucket,
> String, int, byte[]) ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestOmSnapshotFileSystem.java:[line 374]
> M B RR:
> org.apache.hadoop.ozone.om.snapshot.TestSnapshotBackgroundServices.readKeys(List)
> ignores result of
> org.apache.hadoop.ozone.client.io.OzoneInputStream.read(byte[], int, int) At
> TestSnapshotBackgroundServices.java:[line 663]
> M D RV: Return value of SnapshotDiffManager.isKeyInBucket(String, Map,
> String) ignored, but method has no side effect At
> TestSnapshotDiffManager.java:[line 688]
> M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneShellHA.startCluster(OzoneConfiguration)
> At TestOzoneShellHA.java:[line 187]
> M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneShellHA.startCluster(OzoneConfiguration)
> At TestOzoneShellHA.java:[line 186]
> M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
> TestOzoneTenantShell.java:[line 140]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
> TestOzoneTenantShell.java:[line 121]
> M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneTenantShell.init() At
> TestOzoneTenantShell.java:[line 139]
> M B RV: Exceptional return value of java.io.File.delete() ignored in
> org.apache.hadoop.ozone.shell.TestOzoneTenantShell.shutdown() At
> TestOzoneTenantShell.java:[line 166]
> M B RV: Exceptional return value of java.io.File.createNewFile() ignored in
> org.apache.hadoop.ozone.shell.TestReplicationConfigPreference.init() At
> TestReplicationConfigPreference.java:[line 100]
> M B RV: Exceptional return value of java.io.File.mkdirs() ignored in
> org.apache.hadoop.ozone.shell.TestReplicationConfigPreference.init() At
> TestReplicationConfigPreference.java:[line 99]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]