[
https://issues.apache.org/jira/browse/HDDS-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928675#comment-17928675
]
Chia-Chuan Yu commented on HDDS-12387:
--------------------------------------
Morning, [~adoroszlai]
got it, thanks for the reminder.
> Cleanup TestContainerOperations
> -------------------------------
>
> Key: HDDS-12387
> URL: https://issues.apache.org/jira/browse/HDDS-12387
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Nandakumar
> Assignee: Chia-Chuan Yu
> Priority: Minor
>
> - Use {{storageClient}} in place of {{storageContainerLocationClient}} and
> remove {{storageContainerLocationClient}} altogether in the test
> - The
> [comment|https://github.com/apache/ozone/blob/c0da9afea477bea4101fb2f3849d09b9b8591fb1/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestContainerOperations.java#L230]
> {{// All nodes should be returned as they are all in service}} seems
> incorrect, one of the node is in {{DECOMMISSIONING}} state. The code is
> correct in asserting {{numOfdatanodes - 1}}, just the comment is misleading.
> - Use {{cluster().getHddsDatanodes().size()}} instead of [hardcoded
> value|https://github.com/apache/ozone/blob/c0da9afea477bea4101fb2f3849d09b9b8591fb1/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestContainerOperations.java#L266]
> {{5}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
