adoroszlai commented on code in PR #7924: URL: https://github.com/apache/ozone/pull/7924#discussion_r1965018033
########## .editorconfig: ########## Review Comment: Please add license header. https://github.com/ivanzlenko/ozone/actions/runs/13449640732/job/37581721643 ########## CONTRIBUTING.md: ########## @@ -166,16 +162,17 @@ As Ozone uses Apache Maven it can be developed from any IDE. IntelliJ IDEA is a ### Run Ozone from IntelliJ -Ozone components depends on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. +Ozone components depend on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. -As a result, it's easy to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. +As a result, it's straightforward to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. -To start Ozone from IntelliJ: +Ozone project already has pre-defined run configurations shared via standard IDE folder for run configurations: Review Comment: ```suggestion Ozone project has pre-defined run configurations shared via standard IDE folder for run configurations: ``` ########## CONTRIBUTING.md: ########## @@ -166,16 +162,17 @@ As Ozone uses Apache Maven it can be developed from any IDE. IntelliJ IDEA is a ### Run Ozone from IntelliJ -Ozone components depends on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. +Ozone components depend on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. -As a result, it's easy to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. +As a result, it's straightforward to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. -To start Ozone from IntelliJ: +Ozone project already has pre-defined run configurations shared via standard IDE folder for run configurations: + +``` +./.run +``` -1. Stop your IDE -2. Execute the `./hadoop-ozone/dev-support/intellij/install-runconfigs.sh` helper script. -3. Start the IDE -4. New runner definitions are available from the Run menu. +They will be automatically imported into IDE on project import. Review Comment: ```suggestion They will be automatically added to the IDE on project import. ``` ########## CONTRIBUTING.md: ########## @@ -166,16 +162,17 @@ As Ozone uses Apache Maven it can be developed from any IDE. IntelliJ IDEA is a ### Run Ozone from IntelliJ -Ozone components depends on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. +Ozone components depend on maven classpath. We generate classpath descriptor from the maven pom.xml files to use exactly the same classpath at runtime. -As a result, it's easy to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. +As a result, it's straightforward to start _all_ the components from IDE as the right classpath (without provided scope) has already been set. -To start Ozone from IntelliJ: +Ozone project already has pre-defined run configurations shared via standard IDE folder for run configurations: + +``` +./.run Review Comment: ```suggestion .run ``` ########## CONTRIBUTING.md: ########## @@ -125,13 +125,9 @@ Basic code conventions followed by Ozone: These are checked by tools like Checkstyle and RAT. -For IntelliJ users, it is recommended to import and select the Code Style scheme located at: +Ozone checkstyle is shared via .editorconfig configuration file and will be automatically imported when the project is open. Review Comment: ```suggestion Ozone code style is shared via `.editorconfig` configuration file and will be automatically imported when the project is opened. ``` ########## .editorconfig: ########## @@ -0,0 +1,61 @@ +[*] Review Comment: Should we add `root = true`? ########## .editorconfig: ########## @@ -0,0 +1,61 @@ +[*] +charset = utf-8 +end_of_line = lf +indent_size = 2 +indent_style = space +insert_final_newline = false Review Comment: We should ensure EOL on last line is present. ```suggestion insert_final_newline = true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
