[
https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929168#comment-17929168
]
Attila Doroszlai edited comment on HDDS-12388 at 2/21/25 2:24 PM:
------------------------------------------------------------------
Thanks [~chiacyu] for picking this up.
JUnit test can be skipped via assumption, something like:
{code}
try {
cluster.getOzoneManager().checkFeatureEnabled(OzoneManagerVersion.ATOMIC_REWRITE_KEY);
} catch (OMException e) {
assumeFalse(OMException.ResultCodes.NOT_SUPPORTED_OPERATION ==
e.getResult());
}
{code}
Please create a method to avoid duplicating the check.
I think only couple of test cases in OzoneRpcClientTests are affected.
There is also a Robot test, but I think that one will need a more complex
change, I'll create a new task for myself.
was (Author: adoroszlai):
Thanks [~chiacyu] for picking this up.
JUnit test can be skipped via assumption, something like (using
{{org.assertj.core.api.Assumptions}}):
{code}
assumeThat(conf.get(OMConfigKeys.OZONE_OM_FEATURES_DISABLED, ""))
.doesNotContain(OzoneManagerVersion.ATOMIC_REWRITE_KEY.name());
{code}
Please create a method to avoid duplicating the check.
I think only couple of test cases in OzoneRpcClientTests are affected.
There is also a Robot test, but I think that one will need a more complex
change, I'll create a new task for myself.
> Key rewrite tests should be skipped if feature is disabled
> ----------------------------------------------------------
>
> Key: HDDS-12388
> URL: https://issues.apache.org/jira/browse/HDDS-12388
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Chia-Chuan Yu
> Priority: Major
>
> Tests covering atomic key rewrite should handle the case where the feature is
> disabled via config (HDDS-11378).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
